Tests / test (pull_request) Successful in 1m10s
Brings preauth from 18/34 to 30/34 conformance (auth-gateway profile). The
remaining four checks all depend on files this branch cannot change (see below).
PHP toolchain (§1)
- require.php >=8.4 -> ^8.5, and pin config.platform to 8.5.0. The old
constraint also permitted PHP 9, which is not a promise we can keep.
composer.lock regenerated with --lock: content-hash + platform-overrides
only, zero dependency version movement.
- friendsofphp/php-cs-fixer * -> ^3.95. A wildcard meant CI was not
reproducible.
PHPStan (§2.2)
- vendor the shared phpstan.neon.dist (level 6) + a generated baseline.
187 errors are captured rather than fixed; the baseline should only shrink
from here.
- add phpstan/phpstan:^2.1 to require-dev.
Code style (§8.2)
- vendor the shared .php-cs-fixer.dist.php (@Symfony + @Symfony:risky +
declare_strict_types) and apply it: 59 of 67 files reformatted.
- Verified this is a formatting change, not a behaviour change: all 313 tests
pass after the reformat, all in_array() calls already passed strict=true,
and the remaining edits are @Symfony:risky idiom (yoda conditions, \count(),
self:: over the class name).
Repository layout (§4.4)
- docs/{Caddyfile,compose.yaml,example.env} -> docs/examples/, with
example.env becoming the conventional .env.example. This is the layout
GUIDING-LIGHT already cites preauth as doing correctly — it just needed
renaming.
- update the four readme.md references and a stale compose.yaml comment.
- docs/v1.1-plan.md references are left alone deliberately: it is a historical
plan recording what was done at the time, not live documentation.
Licence and security policy (§7)
- add LICENSE (uniform MIT, matching composer.json).
- add SECURITY.md describing the actual threat model: per-request
allow/intercept, no caching of the login flow, app-set security headers,
TOTP, and the fact that REMOTE_USER is trusted input.
Mobile accessibility (§3.3a)
- templates/base.html.twig: drop maximum-scale=1 and add viewport-fit=cover.
preauth was the one app already past the font-size precondition (controls
render at 21.6px = 0.9em x 24px), so removing the lock is safe here and
restores pinch-zoom for Android users.
Conformance tooling (§8.2)
- vendor .ci/conformance.sh and .ci/css-control-size.py so the check runs
from a checkout rather than fetching from the LAN-only private/ci.
- .editorconfig synced from the version that keeps the Caddyfile tab rule.
Not included (blocked by the .gitea/workflows pre-receive hook):
- ci-composer-audit, ci-composer-validate, ci-reusable-workflows.
Workflow files may only change via a trusted ref, so the caller files are
staged but not committed.
Also not included: dockerfile-nonroot (§6.4). Adding USER to an image with
VOLUME [/config, /data] changes volume ownership and needs an actual container
build/run to verify, so it goes in its own change.
303 lines
8.8 KiB
PHP
303 lines
8.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Unit;
|
|
|
|
use App\MonitorCacheKeys;
|
|
use OutOfBoundsException;
|
|
use PHPUnit\Framework\TestCase;
|
|
use Symfony\Component\Cache\Adapter\ArrayAdapter;
|
|
|
|
final class MonitorCacheKeysTest extends TestCase
|
|
{
|
|
private function wrap(?ArrayAdapter $pool = null): MonitorCacheKeys
|
|
{
|
|
$pool ??= new ArrayAdapter();
|
|
|
|
return new MonitorCacheKeys($pool);
|
|
}
|
|
|
|
public function test_constructor_initializes_empty_pool(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
self::assertSame([], $monitor->getKeys());
|
|
self::assertSame([], $monitor->getChanges());
|
|
}
|
|
|
|
public function test_save_adds_key_and_tracks_change(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('alpha');
|
|
$item->set('value');
|
|
$monitor->save($item);
|
|
|
|
self::assertSame(['alpha'], $monitor->getKeys());
|
|
self::assertSame(['alpha' => MonitorCacheKeys::UPDATED], $monitor->getChanges());
|
|
}
|
|
|
|
public function test_save_deferred_then_commit_adds_key(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('beta');
|
|
$item->set('value');
|
|
$monitor->saveDeferred($item);
|
|
|
|
// saveDeferred calls update() which commits immediately
|
|
self::assertSame(['beta'], $monitor->getKeys());
|
|
self::assertSame(['beta' => MonitorCacheKeys::UPDATED], $monitor->getChanges());
|
|
}
|
|
|
|
public function test_get_item_returns_underlying_item(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('mykey');
|
|
$item->set('data');
|
|
$monitor->save($item);
|
|
|
|
$fetched = $monitor->getItem('mykey');
|
|
self::assertTrue($fetched->isHit());
|
|
self::assertSame('data', $fetched->get());
|
|
}
|
|
|
|
public function test_get_items_returns_multiple_items(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$a = $monitor->getItem('a');
|
|
$a->set(1);
|
|
$monitor->save($a);
|
|
$b = $monitor->getItem('b');
|
|
$b->set(2);
|
|
$monitor->save($b);
|
|
|
|
$items = $monitor->getItems(['a', 'b']);
|
|
$keys = [];
|
|
foreach ($items as $key => $item) {
|
|
$keys[$key] = $item->get();
|
|
}
|
|
self::assertSame(['a' => 1, 'b' => 2], $keys);
|
|
}
|
|
|
|
public function test_has_item_returns_true_for_existing_key(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('exists');
|
|
$item->set('v');
|
|
$monitor->save($item);
|
|
|
|
self::assertTrue($monitor->hasItem('exists'));
|
|
self::assertFalse($monitor->hasItem('missing'));
|
|
}
|
|
|
|
public function test_delete_item_removes_key_and_tracks_removal(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('doomed');
|
|
$item->set('v');
|
|
$monitor->save($item);
|
|
|
|
$monitor->deleteItem('doomed');
|
|
|
|
self::assertSame([], $monitor->getKeys());
|
|
self::assertSame(['doomed' => MonitorCacheKeys::REMOVED], $monitor->getChanges());
|
|
self::assertFalse($monitor->hasItem('doomed'));
|
|
}
|
|
|
|
public function test_delete_item_on_missing_key_is_noop(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
$result = $monitor->deleteItem('nonexistent');
|
|
|
|
self::assertTrue($result);
|
|
self::assertSame([], $monitor->getKeys());
|
|
}
|
|
|
|
public function test_delete_items_removes_multiple_keys(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
foreach (['x', 'y', 'z'] as $key) {
|
|
$item = $monitor->getItem($key);
|
|
$item->set($key);
|
|
$monitor->save($item);
|
|
}
|
|
|
|
$monitor->deleteItems(['x', 'y']);
|
|
|
|
self::assertSame(['z'], $monitor->getKeys());
|
|
$changes = $monitor->getChanges();
|
|
self::assertSame(MonitorCacheKeys::REMOVED, $changes['x']);
|
|
self::assertSame(MonitorCacheKeys::REMOVED, $changes['y']);
|
|
}
|
|
|
|
public function test_delete_items_with_missing_keys_still_returns_true(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
$result = $monitor->deleteItems(['ghost1', 'ghost2']);
|
|
|
|
self::assertTrue($result);
|
|
}
|
|
|
|
public function test_clear_wipes_pool_when_not_empty(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('keep');
|
|
$item->set('v');
|
|
$monitor->save($item);
|
|
|
|
$result = $monitor->clear();
|
|
|
|
self::assertTrue($result);
|
|
self::assertSame([], $monitor->getKeys());
|
|
}
|
|
|
|
public function test_clear_is_noop_when_empty(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
$result = $monitor->clear();
|
|
|
|
self::assertTrue($result);
|
|
}
|
|
|
|
public function test_mark_clean_resets_change_list(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('temp');
|
|
$item->set('v');
|
|
$monitor->save($item);
|
|
|
|
self::assertNotEmpty($monitor->getChanges());
|
|
|
|
$monitor->markClean();
|
|
|
|
self::assertSame([], $monitor->getChanges());
|
|
self::assertSame(['temp'], $monitor->getKeys());
|
|
}
|
|
|
|
public function test_commit_passes_through(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
self::assertTrue($monitor->commit());
|
|
}
|
|
|
|
public function test_save_key_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('__key_list');
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->save($item);
|
|
}
|
|
|
|
public function test_save_change_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('__chg_list');
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->save($item);
|
|
}
|
|
|
|
public function test_delete_key_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->deleteItem('__key_list');
|
|
}
|
|
|
|
public function test_delete_change_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->deleteItem('__chg_list');
|
|
}
|
|
|
|
public function test_delete_items_with_key_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->deleteItems(['safe', '__key_list']);
|
|
}
|
|
|
|
public function test_delete_items_with_change_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->deleteItems(['__chg_list']);
|
|
}
|
|
|
|
public function test_save_deferred_on_key_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('safe');
|
|
$item->set('value');
|
|
|
|
// getItem returns the real item, but saveDeferred calls update() which
|
|
// validates the key — so we need to get the __key_list item and try to save it
|
|
$keyListItem = $monitor->getItem('__key_list');
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->saveDeferred($keyListItem);
|
|
}
|
|
|
|
public function test_save_deferred_on_change_list_throws_out_of_bounds_exception(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$changeListItem = $monitor->getItem('__chg_list');
|
|
|
|
$this->expectException(OutOfBoundsException::class);
|
|
$monitor->saveDeferred($changeListItem);
|
|
}
|
|
|
|
public function test_get_keys_returns_empty_array_when_key_list_missing(): void
|
|
{
|
|
// If the underlying pool loses its key list, getKeys should return []
|
|
$pool = new ArrayAdapter();
|
|
$monitor = new MonitorCacheKeys($pool);
|
|
|
|
$item = $monitor->getItem('alpha');
|
|
$item->set('value');
|
|
$monitor->save($item);
|
|
|
|
// delete the key list directly from the underlying pool
|
|
$pool->deleteItem('__key_list');
|
|
|
|
$monitor2 = new MonitorCacheKeys($pool);
|
|
// the constructor will re-initialize since __key_list is missing
|
|
// but getKeys on the new monitor should be empty
|
|
self::assertSame([], $monitor2->getKeys());
|
|
}
|
|
|
|
public function test_delete_item_returns_true_for_existing_key(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
$item = $monitor->getItem('to-delete');
|
|
$item->set('value');
|
|
$monitor->save($item);
|
|
|
|
self::assertTrue($monitor->deleteItem('to-delete'));
|
|
self::assertNotContains('to-delete', $monitor->getKeys());
|
|
}
|
|
|
|
public function test_delete_items_returns_true(): void
|
|
{
|
|
$monitor = $this->wrap();
|
|
foreach (['a', 'b', 'c'] as $key) {
|
|
$item = $monitor->getItem($key);
|
|
$item->set('value');
|
|
$monitor->save($item);
|
|
}
|
|
|
|
self::assertTrue($monitor->deleteItems(['a', 'b', 'c']));
|
|
self::assertSame([], $monitor->getKeys());
|
|
}
|
|
}
|