public/preauth
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add .dockerignore, fix broken base64url padding, fix typo, clean up docs #2

Closed
lyra wants to merge 0 commits from fix/docs-and-polish into main
pull from: fix/docs-and-polish
merge into: :main
Conversation 0 Commits - Files Changed -
lyra commented 2026-08-10 18:58:00 -04:00
Member
Copy Link
Copy Source

Changes

.dockerignore (new file)

Created .dockerignore excluding .git/, var/, vendor/, tests/, .phpunit.cache/, docs/, *.md, .env, .env.test, .env.local, composer.phar, .gitignore from the Docker build context. Verified against the Dockerfile — none of these are needed during build.

Broken base64url Padding

Fixed Payload::decode() in src/Data/Payload.php. The original str_pad(strtr($base64url, '-_', '+/'), strlen($base64url) % 4, '=') was a no-op — strlen($base64url) % 4 (0–3) was always less than the string length, so str_pad never added padding. Replaced with correct approach using str_repeat('=', (4 - strlen($base64) % 4) % 4).

Typo Fix

bin/franken.sh: Fixed digtialadapt → digitaladapt (both occurrences). Added a comment noting it's a dev utility, not for production use.

Stale Documentation

  • config/reference.php: Removed from git tracking (git rm --cached) — auto-generated Symfony file, 844 lines. Added to .gitignore.
  • README.md: Fixed stale reference "env.example file" → "example.env file" (matching the actual filename).

Testing

  • ✅ All 222 tests pass (469 assertions)
## Changes ### .dockerignore (new file) Created `.dockerignore` excluding `.git/`, `var/`, `vendor/`, `tests/`, `.phpunit.cache/`, `docs/`, `*.md`, `.env`, `.env.test`, `.env.local`, `composer.phar`, `.gitignore` from the Docker build context. Verified against the Dockerfile — none of these are needed during build. ### Broken base64url Padding Fixed `Payload::decode()` in `src/Data/Payload.php`. The original `str_pad(strtr($base64url, '-_', '+/'), strlen($base64url) % 4, '=')` was a no-op — `strlen($base64url) % 4` (0–3) was always less than the string length, so `str_pad` never added padding. Replaced with correct approach using `str_repeat('=', (4 - strlen($base64) % 4) % 4)`. ### Typo Fix `bin/franken.sh`: Fixed `digtialadapt` → `digitaladapt` (both occurrences). Added a comment noting it's a dev utility, not for production use. ### Stale Documentation - **config/reference.php**: Removed from git tracking (`git rm --cached`) — auto-generated Symfony file, 844 lines. Added to `.gitignore`. - **README.md**: Fixed stale reference "env.example file" → "example.env file" (matching the actual filename). ## Testing - ✅ All 222 tests pass (469 assertions)
lyra added 1 commit 2026-08-10 18:58:00 -04:00
Fix docs, add .dockerignore, fix base64url padding, fix typo
Tests / test (pull_request) Successful in 42s
Details
Sync GitHub / sync (push) Successful in 7s
Details
6b5a711fa9 
- Add .dockerignore to exclude .git, vendor, var, tests, docs, .env
  and other non-build files from Docker context
- Fix broken base64url padding in src/Data/Payload.php: str_pad was
  a no-op because the length argument was always < string length.
  Replaced with correct str_repeat approach
- Fix typo in bin/franken.sh: digtialadapt → digitaladapt
- Add comment to bin/franken.sh noting it's a dev utility
- Remove config/reference.php from git tracking (auto-generated file)
  and add to .gitignore
- Fix readme.md: env.example → example.env (matches actual filename)
andrew closed this pull request 2026-08-11 09:59:05 -04:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andrew (Andrew) lyra
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: public/preauth#2