fix: handle apostrophes for names ending in x (#4343)

* fix: handle apostrophes for names ending in x

* review

---------

Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
This commit is contained in:
Małgorzata (Gosia)
2025-09-10 18:32:30 +03:00
committed by GitHub
co-authored by Alexandr
parent b0b14091e7
commit ea6ef1124d
2 changed files with 2 additions and 4 deletions
+1 -3
View File
@@ -254,9 +254,7 @@ const renderStatsCard = (stats, options = {}) => {
theme,
});
const apostrophe = ["x", "s"].includes(name.slice(-1).toLocaleLowerCase())
? ""
: "s";
const apostrophe = /s$/i.test(name.trim()) ? "" : "s";
const i18n = new I18n({
locale,
translations: statCardLocales({ name, apostrophe }),
+1 -1
View File
@@ -71,7 +71,7 @@ describe("Test renderStatsCard", () => {
document.body.innerHTML = renderStatsCard({ ...stats, name: "Felix" });
expect(document.getElementsByClassName("header")[0].textContent).toBe(
"Felix' GitHub Stats",
"Felix's GitHub Stats",
);
});